Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DataFrame optimalization #97

Merged
merged 6 commits into from
Jun 2, 2020
Merged

feat: DataFrame optimalization #97

merged 6 commits into from
Jun 2, 2020

Conversation

rolincova
Copy link
Contributor

@rolincova rolincova commented May 20, 2020 •
edited by bednar
Loading

Closes #92
Closes #99

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@rolincova rolincova requested a review from bednar May 20, 2020 10:06
@rolincova rolincova changed the title Feat/dataframe optimalization feat: DataFrame optimalization May 20, 2020
@rolincova
Copy link
Contributor Author

We reached in test on 1500000 records from 170s to 70s which is 60% faster.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020 •
edited
Loading

Codecov Report

Merging #97 into master will decrease coverage by 0.03%.
The diff coverage is 92.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   88.66%   88.62%   -0.04%     
==========================================
  Files          22       22              
  Lines        1747     1794      +47     
==========================================
+ Hits         1549     1590      +41     
- Misses        198      204       +6
Impacted Files Coverage Δ
influxdb_client/extras.py 55.55% <60.00%> (-4.45%) ⬇️
influxdb_client/client/write_api.py 96.52% <94.64%> (-0.81%) ⬇️
influxdb_client/client/delete_api.py 100.00% <100.00%> (ø)
influxdb_client/client/bucket_api.py 90.62% <0.00%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68cf1a...3a56509. Read the comment docs.

@bednar bednar mentioned this pull request May 25, 2020
Closed
@bednar bednar added this to the 1.8.0 milestone Jun 2, 2020
@bednar bednar merged commit 4ecce15 into master Jun 2, 2020
@bednar bednar deleted the feat/dataframe-optimalization branch June 2, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

dataframe with Int64 type upload error The DataFrame serialisation is slower than in v1
3 participants
@rolincova @codecov-commenter @bednar